Init "0-click connection" flow for the Ledger Live App #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To support "0-click connection" flow for the Ledger Live app.
Closed
We use the `@rehooks/local-storage` library, which saves undefined as a string. Therefore, we need to check the value of "undefined".
To update the conection flow.
nkuba
reviewed
Oct 1, 2024
We want the flow to be as close to the original as possible, so here we simulate the session mechanism.
nkuba
approved these changes
Oct 2, 2024
nkuba
added a commit
that referenced
this pull request
Nov 6, 2024
This is an integration PR that adds the necessary changes for the dapp to run on Ledger Live. Refs: #730 #742 #763 #759, #760, #797, #780, mezo-org/passport#143, mezo-org/passport#144 ### Important note Changes can only be tested in a Ledger Live app built from source. See the [Ledger Live repo](https://github.com/LedgerHQ/ledger-live), how to build from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
What has been done: